Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify REALIP method #1193

Merged
merged 2 commits into from
Sep 19, 2018
Merged

Simplify REALIP method #1193

merged 2 commits into from
Sep 19, 2018

Conversation

ribice
Copy link
Contributor

@ribice ribice commented Sep 8, 2018

No description provided.

@codecov
Copy link

codecov bot commented Sep 8, 2018 •
edited
Loading

Codecov Report

Merging #1193 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1193      +/-   ##
=========================================
+ Coverage   81.46%   81.5%   +0.04%     
=========================================
  Files          25      25              
  Lines        1915    1914       -1     
=========================================
  Hits         1560    1560              
+ Misses        249     248       -1     
  Partials      106     106
Impacted Files Coverage Δ
context.go 73.97% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688ab2b...648bf02. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #1193 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1193      +/-   ##
=========================================
+ Coverage   81.46%   81.5%   +0.04%     
=========================================
  Files          25      25              
  Lines        1915    1914       -1     
=========================================
  Hits         1560    1560              
+ Misses        249     248       -1     
  Partials      106     106
Impacted Files Coverage Δ
context.go 73.97% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688ab2b...648bf02. Read the comment docs.

@im-kulikov
Copy link
Contributor

@vishr can you restart travis?

im-kulikov
im-kulikov approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@im-kulikov im-kulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (rerun travis)

@vishr vishr merged commit a2d4cb9 into labstack:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-kulikov im-kulikov im-kulikov approved these changes

Assignees

@ribice ribice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ribice @im-kulikov @vishr